Mention collections.abc for Sequence · gitpython-developers/GitPython@3c8cbe9 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 3c8cbe9

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Mention collections.abc for Sequence

In the deprecation comment for importing Sequence from the top level git module. Although the git module imports it from typing, collections.abc.Sequence supports __class_getitem__ since Python 3.9 (and typing.Sequence is actually itself deprecated since then).

1 parent c8ad3a3 commit 3c8cbe9
Copy full SHA for 3c8cbe9

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • __init__.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/__init__.py‎

Copy file name to clipboardExpand all lines: git/__init__.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -58,7 +58,7 @@
58	58	"RepositoryDirtyError",
59	59	"RootModule",
60	60	"RootUpdateProgress",
61		- "Sequence", # Deprecated - import this from `typing` instead.
	61	+ "Sequence", # Deprecated - import from `typing`, or `collections.abc` in 3.9+.
62	62	"StageType",
63	63	"Stats",
64	64	"Submodule",

0 commit comments

Comments

0 (0)