Repository navigation
Commit 484b3df
Use g for formatting floating point timeouts
The timeout error message formats `timeout` with `%d`, but `kill_after_timeout` is typed as `float` and is commonly passed as a non-integer (e.g., 0.1). This can produce a misleading message (truncation to 0) and may raise a formatting error depending on Python behavior. Format it as a float (or generic number) instead.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>1 parent 59efde9 commit 484b3df
1 file changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1473,10 +1473,7 @@ def kill_process(pid: int) -> None: | |||
| 1473 | 1473 | return | |
| 1474 | 1474 | ||
| 1475 | 1475 | def make_timeout_error() -> Union[str, bytes]: | |
| 1476 | - err = 'Timeout: the command "%s" did not complete in %d secs.' % ( | ||
| 1477 | - " ".join(redacted_command), | ||
| 1478 | - timeout, | ||
| 1479 | - ) | ||
| 1476 | + err = f'Timeout: the command "{" ".join(redacted_command)}" did not complete in {timeout:g} secs.' | ||
| 1480 | 1477 | return err if universal_newlines else err.encode(defenc) | |
| 1481 | 1478 | ||
| 1482 | 1479 | def communicate() -> Tuple[AnyStr, AnyStr]: | |
0 commit comments