Do not break convention when updating sys.path · gitpython-developers/GitPython@4ba76d6 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 4ba76d6

Browse filesBrowse the repository at this point in the historyBrowse files

Xavier Verges

authored and

Byron

committed

Do not break convention when updating sys.path

1 parent 7cd47ae commit 4ba76d6
Copy full SHA for 4ba76d6

2 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • __init__.py
• test
  • test_installation.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/__init__.py‎

Copy file name to clipboardExpand all lines: git/__init__.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -19,7 +19,7 @@
19	19	def _init_externals():
20	20	"""Initialize external projects by putting them into the path"""
21	21	if __version__ == 'git' and 'PYOXIDIZER' not in os.environ:
22		- sys.path.insert(0, osp.join(osp.dirname(__file__), 'ext', 'gitdb'))
	22	+ sys.path.insert(1, osp.join(osp.dirname(__file__), 'ext', 'gitdb'))
23	23
24	24	try:
25	25	import gitdb

Collapse file

‎test/test_installation.py‎

Copy file name to clipboardExpand all lines: test/test_installation.py

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,7 @@
1	1	# This module is part of GitPython and is released under
2	2	# the BSD License: http://www.opensource.org/licenses/bsd-license.php
3	3
	4	+ import ast
4	5	import os
5	6	import subprocess
6	7	from test.lib import TestBase
@@ -27,3 +28,8 @@ def test_installation(self, rw_dir):
27	28	self.assertEqual(0, result.returncode, msg=result.stderr or result.stdout or "Can't build - setup.py failed")
28	29	result = subprocess.run([self.python, '-c', 'import git'], stdout=subprocess.PIPE, cwd=self.sources)
29	30	self.assertEqual(0, result.returncode, msg=result.stderr or result.stdout or "Selftest failed")
	31	+ result = subprocess.run([self.python, '-c', 'import sys;import git; print(sys.path)'], stdout=subprocess.PIPE, cwd=self.sources)
	32	+ syspath = result.stdout.decode('utf-8').splitlines()[0]
	33	+ syspath = ast.literal_eval(syspath)
	34	+ self.assertEqual('', syspath[0], msg='Failed to follow the conventions for https://docs.python.org/3/library/sys.html#sys.path')
	35	+ self.assertTrue(syspath[1].endswith('gitdb'), msg='Failed to add gitdb to sys.path')

0 commit comments

Comments

0 (0)