Test that ConfigParser treats empty quotes as an empty value · gitpython-developers/GitPython@4ebe407 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 4ebe407

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Test that ConfigParser treats empty quotes as an empty value

The ConfigParser has supported this for a long time, but it is now done redundantly since #2035. This adds a test for it, both to make clearer that it is intended to work and to allow verifying that it continues to hold once the legacy special-casing for it is removed.

1 parent 63160de commit 4ebe407
Copy full SHA for 4ebe407

2 files changed

+6Lines changed: 6 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • fixtures
    • git_config_with_empty_quotes
  • test_config.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/fixtures/git_config_with_empty_quotes‎

Copy file name to clipboard

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,2 @@
	1	+ [core]
	2	+ filemode = ""

Collapse file

‎test/test_config.py‎

Copy file name to clipboardExpand all lines: test/test_config.py

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -416,6 +416,10 @@ def test_config_with_quotes(self):
416	416	self.assertEqual(cr.get("user", "name"), "Cody Veal")
417	417	self.assertEqual(cr.get("user", "email"), "cveal05@gmail.com")
418	418
	419	+ def test_config_with_empty_quotes(self):
	420	+ cr = GitConfigParser(fixture_path("git_config_with_empty_quotes"), read_only=True)
	421	+ self.assertEqual(cr.get("core", "filemode"), "", "quotes can form a literal empty string as value")
	422	+
419	423	def test_config_with_quotes_with_literal_whitespace(self):
420	424	cr = GitConfigParser(fixture_path("git_config_with_quotes_whitespace_inside"), read_only=True)
421	425	self.assertEqual(cr.get("core", "commentString"), "# ")

0 commit comments

Comments

0 (0)