Address review feedback about config section casing · gitpython-developers/GitPython@5252136 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 5252136

Browse filesBrowse the repository at this point in the historyBrowse files

codex

authored and

Byron

committed

Address review feedback about config section casing

Review feedback: Git accepts core section names case-insensitively, while GitConfigParser preserves section casing and the hook lookup only inspected a literal core section. Aggregate options from every section whose name case-folds to core before selecting the effective hooksPath value. Extend the regression configuration to use mixed casing for both the section and option names.

1 parent fafbdc8 commit 5252136
Copy full SHA for 5252136

2 files changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/index
  • fun.py
• test
  • test_index.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/index/fun.py‎

Copy file name to clipboardExpand all lines: git/index/fun.py

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -67,7 +67,9 @@ def hook_path(name: str, git_dir: PathLike) -> str:
67	67	def _commit_hook_path(name: str, index: "IndexFile") -> str:
68	68	""":return: path to the named commit hook, respecting Git's core.hooksPath."""
69	69	with index.repo.config_reader() as config:
70		- core_items = config.items("core") if config.has_section("core") else []
	70	+ core_items = [
	71	+ item for section in config.sections() if section.lower() == "core" for item in config.items(section)
	72	+ ]
71	73	hooks_dir = next((value for option, value in reversed(core_items) if option.lower() == "hookspath"), None)
72	74
73	75	if not hooks_dir:

Collapse file

‎test/test_index.py‎

Copy file name to clipboardExpand all lines: test/test_index.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1206,7 +1206,7 @@ def test_pre_commit_hook_respects_core_hooks_path(self, rw_repo):
1206	1206	os.chmod(hp, 0o744)
1207	1207
1208	1208	with index.repo.config_writer() as writer:
1209		- writer.set_value("core", "HoOkSpAtH", "custom-hooks")
	1209	+ writer.set_value("CoRe", "HoOkSpAtH", "custom-hooks")
1210	1210
1211	1211	index.commit("This should run the custom hook")
1212	1212	output = Path(rw_repo.working_dir, "custom-hook-output.txt").read_text(encoding="utf-8")

0 commit comments

Comments

0 (0)