Merge pull request #2268 from Keerthana-64/gpgsig-linear-parse · gitpython-developers/GitPython@574aec2 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues7 (7)
• Pull requests3 (3)
• Discussions
• Actions
• Security and quality41 (41)
• Insights

Commit 574aec2

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

authored

Merge pull request #2268 from Keerthana-64/gpgsig-linear-parse

fix(commit): accumulate gpgsig continuation lines in linear time

2 parents 6306c5c + 5fc5f34 commit 574aec2
Copy full SHA for 574aec2

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/objects
  • commit.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/objects/commit.py‎

Copy file name to clipboardExpand all lines: git/objects/commit.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -885,7 +885,7 @@ def _deserialize(self, stream: BytesIO) -> "Commit":
885	885	if buf[0:10] == b"encoding ":
886	886	self.encoding = buf[buf.find(b" ") + 1 :].decode(self.encoding, "ignore")
887	887	elif buf[0:7] == b"gpgsig ":
888		- sig = buf[buf.find(b" ") + 1 :] + b"\n"
	888	+ sig_lines = [buf[buf.find(b" ") + 1 :] + b"\n"]
889	889	is_next_header = False
890	890	while True:
891	891	sigbuf = readline()
@@ -895,9 +895,9 @@ def _deserialize(self, stream: BytesIO) -> "Commit":
895	895	buf = sigbuf.strip()
896	896	is_next_header = True
897	897	break
898		- sig += sigbuf[1:]
	898	+ sig_lines.append(sigbuf[1:])
899	899	# END read all signature
900		- self.gpgsig = sig.rstrip(b"\n").decode(self.encoding, "ignore")
	900	+ self.gpgsig = b"".join(sig_lines).rstrip(b"\n").decode(self.encoding, "ignore")
901	901	if is_next_header:
902	902	continue
903	903	buf = readline().strip()

0 commit comments

Comments

0 (0)