fix: replace deprecated codecs.open with built-in open (#128) · gitpython-developers/GitPython@5e74292 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests7 (7)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit 5e74292

Browse filesBrowse the repository at this point in the historyBrowse files

mvanhorn

committed

fix: replace deprecated codecs.open with built-in open (#128)

Python 3.14 emits a DeprecationWarning for codecs.open(), which gitdb hits inside ReferenceDB._update_dbs_from_ref_file: DeprecationWarning: codecs.open() is deprecated. Use open() instead. The built-in open() has supported the encoding kwarg since Python 3.0 and the call site already passes encoding="utf-8", so the replacement is byte-for-byte equivalent on every supported Python version. Dropped the now-unused codecs import. Verified the change with the existing test_ref.py suite. Closes #128

1 parent 5c1b303 commit 5e74292
Copy full SHA for 5e74292

1 file changed

+1-2Lines changed: 1 addition & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitdb/db
  • ref.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitdb/db/ref.py‎

Copy file name to clipboardExpand all lines: gitdb/db/ref.py

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -2,7 +2,6 @@
2	2	#
3	3	# This module is part of GitDB and is released under
4	4	# the New BSD License: https://opensource.org/license/bsd-3-clause/
5		- import codecs
6	5	from gitdb.db.base import (
7	6	CompoundDB,
8	7	)
@@ -42,7 +41,7 @@ def _update_dbs_from_ref_file(self):
42	41	# try to get as many as possible, don't fail if some are unavailable
43	42	ref_paths = list()
44	43	try:
45		- with codecs.open(self._ref_file, 'r', encoding="utf-8") as f:
	44	+ with open(self._ref_file, 'r', encoding="utf-8") as f:
46	45	ref_paths = [l.strip() for l in f]
47	46	except OSError:
48	47	pass

0 commit comments

Comments

0 (0)