BF: Allow to remove a submodule with a remote without refs · gitpython-developers/GitPython@6497d1e · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests8 (8)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit 6497d1e

Browse filesBrowse the repository at this point in the historyBrowse files

yarikoptic

authored and

ankostis

committed

BF: Allow to remove a submodule with a remote without refs

1 parent 8a01ec4 commit 6497d1e
Copy full SHA for 6497d1e

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/objects/submodule
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -836,7 +836,7 @@ def remove(self, module=True, force=False, configuration=True, dry_run=False):
836	836	num_branches_with_new_commits += len(mod.git.cherry(rref)) != 0
837	837	# END for each remote ref
838	838	# not a single remote branch contained all our commits
839		- if num_branches_with_new_commits == len(rrefs):
	839	+ if len(rrefs) and num_branches_with_new_commits == len(rrefs):
840	840	raise InvalidGitRepositoryError(
841	841	"Cannot delete module at %s as there are new commits" % mod.working_tree_dir)
842	842	# END handle new commits

0 commit comments

Comments

0 (0)