Allow mmap not just for py2.6/2.7/3.6+ but also 3.0+ · gitpython-developers/GitPython@693b171 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 693b171

Browse filesBrowse the repository at this point in the historyBrowse files

hugovk

committed

Allow mmap not just for py2.6/2.7/3.6+ but also 3.0+

1 parent 190c045 commit 693b171
Copy full SHA for 693b171

1 file changed

+1-9Lines changed: 1 addition & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/index
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/index/base.py‎

Copy file name to clipboardExpand all lines: git/index/base.py

+1-9Lines changed: 1 addition & 9 deletions

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,6 @@
8	8	import os
9	9	from stat import S_ISLNK
10	10	import subprocess
11		- import sys
12	11	import tempfile
13	12
14	13	from git.compat import (
@@ -18,7 +17,6 @@
18	17	force_bytes,
19	18	defenc,
20	19	mviter,
21		- is_win
22	20	)
23	21	from git.exc import (
24	22	GitCommandError,
@@ -128,13 +126,7 @@ def _set_cache_(self, attr):
128	126	lfd.rollback()
129	127	# END exception handling
130	128
131		- # Here it comes: on windows in python 2.5, memory maps aren't closed properly
132		- # Hence we are in trouble if we try to delete a file that is memory mapped,
133		- # which happens during read-tree.
134		- # In this case, we will just read the memory in directly.
135		- # Its insanely bad ... I am disappointed !
136		- allow_mmap = (is_win or sys.version_info[1] > 5)
137		- stream = file_contents_ro(fd, stream=True, allow_mmap=allow_mmap)
	129	+ stream = file_contents_ro(fd, stream=True, allow_mmap=True)
138	130
139	131	try:
140	132	self._deserialize(stream)

0 commit comments

Comments

0 (0)