Merge pull request #184 from SurveyMonkey/GH-145_fix_git_push_hang · gitpython-developers/GitPython@6d3d94c · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests7 (7)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit 6d3d94c

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Merge pull request #184 from SurveyMonkey/GH-145_fix_git_push_hang

Fix `git push` hanging when stdout/stderr is big

2 parents a66cfe9 + 3d0e05c commit 6d3d94c
Copy full SHA for 6d3d94c

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/db/cmd
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/db/cmd/base.py‎

Copy file name to clipboardExpand all lines: git/db/cmd/base.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -127,10 +127,11 @@ def get_push_info(repo, remotename_or_url, proc, progress):
127	127	# we hope stdout can hold all the data, it should ...
128	128	# read the lines manually as it will use carriage returns between the messages
129	129	# to override the previous one. This is why we read the bytes manually
130		- digest_process_messages(proc.stderr, progress)
	130	+ stdout, stderr = proc.communicate()
	131	+ digest_process_messages(StringIO(stderr), progress)
131	132
132	133	output = IterableList('name')
133		- for line in proc.stdout.readlines():
	134	+ for line in stdout.splitlines():
134	135	try:
135	136	output.append(CmdPushInfo._from_line(repo, remotename_or_url, line))
136	137	except ValueError:
@@ -139,7 +140,6 @@ def get_push_info(repo, remotename_or_url, proc, progress):
139	140	# END exception handling
140	141	# END for each line
141	142
142		- finalize_process(proc)
143	143	return output
144	144
145	145

0 commit comments

Comments

0 (0)