Commit 70ef69a
committed
Include TagObject in git.types.Tree_ish
The Tree_ish union omitted TagObject, whose instances are only
sometimes tree-ish, and unlike Commit_ish before #1859, it is not
inherently a bug to define Tree_ish this way.
However, this Tree_ish type actually has only one use in GitPython
(which was also the case before the changes in #1859): as, itself,
an alternative in the union used to annotate the rev parameter of
the Repo.tree method (whose other alternatives are str and None).
A TagObject may be passed, and if it points to a tree or commit
then that will be resolved. Just to avoid a mypy error, code doing
that would (before this change) have to convert it to str first.
That annotation should be improved, and the best way to do it is to
keep it written the same way but change the definition of Tree_ish
in git.types to include TagObject. The reason is that doing so
alleviates a major unintuitive aspect of the relationship between
the Commit_ish and Tree_ish types: Commit_ish was broader than
everything commit-ish, while Tree_ish was narrower than everything
tree-ish.
I had not considered making this change in #1859 because I didn't
want to modify Tree_ish unnecessarily, and its definition was not
inherently a bug. However, the change to Commit_ish is sufficiently
large (though it only affects static typing) that a change to
Tree_ish to make them coherent and intuitive may be justified.
This commit changes Tree_ish so that, in addition to its Commit and
Tree alternatives, it also includes TagObject. This also updates
and simplifies its docstring accordingly, bringing it in line with
that of Commit_ish which is already defined with the same kind of
breadth, and further revises both docstrings to more explicitly
clarify when tags are tree-ish or commit-ish and when they are not.
This does not change the separate nonpublic Treeish type defined in
git.index.base (and named with no underscore), which omits
TagObject but includes bytes and str, and which is used to annotate
parameters of the IndexFile.from_tree and IndexFile.merge_tree
methods. Changes there may be valuable, but the goal here is just
to build narrowly on #1859 to address a shortcoming of the
revisions to git.types.1 parent bcea9a8 commit 70ef69a
1 file changed
Lines changed: 10 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,19 +73,18 @@ | |||
| 73 | 73 | See also the :class:`Tree_ish` and :class:`Commit_ish` unions. | |
| 74 | 74 | """ | |
| 75 | 75 | ||
| 76 | - Tree_ish = Union["Commit", "Tree"] | ||
| 77 | - """Union of :class:`~git.objects.base.Object`-based types that are inherently tree-ish. | ||
| 76 | + Tree_ish = Union["Commit", "Tree", "TagObject"] | ||
| 77 | + """Union of :class:`~git.objects.base.Object`-based types that are sometimes tree-ish. | ||
| 78 | 78 | ||
| 79 | 79 | See gitglossary(7) on "tree-ish": https://git-scm.com/docs/gitglossary#def_tree-ish | |
| 80 | 80 | ||
| 81 | 81 | :note: | |
| 82 | - This union comprises **only** the :class:`~git.objects.commit.Commit` and | ||
| 83 | - :class:`~git.objects.tree.Tree` classes, **all** of whose instances are tree-ish. | ||
| 84 | - This has been done because of the way GitPython uses it as a static type annotation. | ||
| 85 | - | ||
| 86 | - :class:`~git.objects.tag.TagObject`, some but not all of whose instances are | ||
| 87 | - tree-ish (those representing git tag objects that ultimately resolve to a tree or | ||
| 88 | - commit), is not covered as part of this union type. | ||
| 82 | + :class:`~git.objects.tree.Tree` and :class:`~git.objects.commit.Commit` are the | ||
| 83 | + classes whose instances are all tree-ish. This union includes them, but also | ||
| 84 | + :class:`~git.objects.tag.TagObject`, only **some** of whose instances are tree-ish. | ||
| 85 | + Whether a particular :class:`~git.objects.tag.TagObject` peels (recursively | ||
| 86 | + dereferences) to a tree or commit, rather than a blob, can in general only be known | ||
| 87 | + at runtime. | ||
| 89 | 88 | ||
| 90 | 89 | :note: | |
| 91 | 90 | See also the :class:`AnyGitObject` union of all four classes corresponding to git | |
@@ -102,12 +101,8 @@ | |||
| 102 | 101 | commit-ish. This union type includes :class:`~git.objects.commit.Commit`, but also | |
| 103 | 102 | :class:`~git.objects.tag.TagObject`, only **some** of whose instances are | |
| 104 | 103 | commit-ish. Whether a particular :class:`~git.objects.tag.TagObject` peels | |
| 105 | - (recursively dereferences) to a commit can in general only be known at runtime. | ||
| 106 | - | ||
| 107 | - :note: | ||
| 108 | - This is an inversion of the situation with :class:`Tree_ish`. This union is broader | ||
| 109 | - than all commit-ish objects, while :class:`Tree_ish` is narrower than all tree-ish | ||
| 110 | - objects. | ||
| 104 | + (recursively dereferences) to a commit, rather than a tree or blob, can in general | ||
| 105 | + only be known at runtime. | ||
| 111 | 106 | ||
| 112 | 107 | :note: | |
| 113 | 108 | See also the :class:`AnyGitObject` union of all four classes corresponding to git | |
0 commit comments