Merge pull request #2109 from EliahKagan/312-more-gc · gitpython-developers/GitPython@82b7065 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 82b7065

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

authored

Merge pull request #2109 from EliahKagan/312-more-gc

Run `gc.collect()` twice in `test_rename` on Python 3.12

2 parents c0a3d5f + 98b78d2 commit 82b7065
Copy full SHA for 82b7065

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_submodule.py‎

Copy file name to clipboardExpand all lines: test/test_submodule.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1011,6 +1011,7 @@ def test_rename(self, rwdir):
1011	1011	# garbage collector detailed in https://github.com/python/cpython/issues/97922.)
1012	1012	if sys.platform == "win32" and sys.version_info >= (3, 12):
1013	1013	gc.collect()
	1014	+ gc.collect() # Some finalizer scenarios need two collections, at least in theory.
1014	1015
1015	1016	new_path = "renamed/myname"
1016	1017	assert sm.move(new_path).name == new_path

0 commit comments

Comments

0 (0)