Unnecessary generator - rewrite as a list comprehension · gitpython-developers/GitPython@87a6441 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 87a6441

Browse filesBrowse the repository at this point in the historyBrowse files

hugovk

committed

Unnecessary generator - rewrite as a list comprehension

1 parent 34cce40 commit 87a6441
Copy full SHA for 87a6441

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/test
  • test_index.py
  • test_tree.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/test/test_index.py‎

Copy file name to clipboardExpand all lines: git/test/test_index.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -127,7 +127,7 @@ def test_index_file_base(self):
127	127	# test stage
128	128	index_merge = IndexFile(self.rorepo, fixture_path("index_merge"))
129	129	self.assertEqual(len(index_merge.entries), 106)
130		- assert len(list(e for e in index_merge.entries.values() if e.stage != 0))
	130	+ assert len([e for e in index_merge.entries.values() if e.stage != 0])
131	131
132	132	# write the data - it must match the original
133	133	tmpfile = tempfile.mktemp()
@@ -190,7 +190,7 @@ def test_index_file_from_tree(self, rw_repo):
190	190
191	191	# merge three trees - here we have a merge conflict
192	192	three_way_index = IndexFile.from_tree(rw_repo, common_ancestor_sha, cur_sha, other_sha)
193		- assert len(list(e for e in three_way_index.entries.values() if e.stage != 0))
	193	+ assert len([e for e in three_way_index.entries.values() if e.stage != 0])
194	194
195	195	# ITERATE BLOBS
196	196	merge_required = lambda t: t[0] != 0

Collapse file

‎git/test/test_tree.py‎

Copy file name to clipboardExpand all lines: git/test/test_tree.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -79,7 +79,7 @@ def test_traverse(self):
79	79	# only choose trees
80	80	trees_only = lambda i, d: i.type == "tree"
81	81	trees = list(root.traverse(predicate=trees_only))
82		- assert len(trees) == len(list(i for i in root.traverse() if trees_only(i, 0)))
	82	+ assert len(trees) == len([i for i in root.traverse() if trees_only(i, 0)])
83	83
84	84	# test prune
85	85	lib_folder = lambda t, d: t.path == "lib"

0 commit comments

Comments

0 (0)