Fixed critical issue that would cause a string to be passed to metho… · gitpython-developers/GitPython@8828ced · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit 8828ced

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Fixed critical issue that would cause a string to be passed to methods that expect a stream

1 parent a5a75ab commit 8828ced
Copy full SHA for 8828ced

2 files changed

+2-4Lines changed: 2 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • refs
    • log.py
  • test
    • test_reflog.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/refs/log.py‎

Copy file name to clipboardExpand all lines: git/refs/log.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -130,7 +130,7 @@ def __init__(self, filepath=None):
130	130
131	131	def _read_from_file(self):
132	132	try:
133		- fmap = file_contents_ro_filepath(self._path, stream=False, allow_mmap=True)
	133	+ fmap = file_contents_ro_filepath(self._path, stream=True, allow_mmap=True)
134	134	except OSError:
135	135	# it is possible and allowed that the file doesn't exist !
136	136	return

Collapse file

‎git/test/test_reflog.py‎

Copy file name to clipboardExpand all lines: git/test/test_reflog.py

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -34,9 +34,7 @@ def test_base(self):
34	34	tdir = tempfile.mktemp(suffix="test_reflogs")
35	35	os.mkdir(tdir)
36	36
37		- # verify we have a ref - with the creation of a new ref, the reflog
38		- # will be created as well
39		- rlp_master_ro = RefLog.path(self.rorepo.heads.master)
	37	+ rlp_master_ro = RefLog.path(self.rorepo.head)
40	38	assert os.path.isfile(rlp_master_ro)
41	39
42	40	# simple read

0 commit comments

Comments

0 (0)