Setting universal_newlines=False explicitly in fetch() and pull(). · gitpython-developers/GitPython@938f272 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests7 (7)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit 938f272

Browse filesBrowse the repository at this point in the historyBrowse files

jcole-crowdstrike

committed

Setting universal_newlines=False explicitly in fetch() and pull().

This fix avoids encoding problems on Windows, as was done for fetch() in the previous commit. However, here it is being made more explicit and adds the same fix for the pull function.

1 parent 4810491 commit 938f272
Copy full SHA for 938f272

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • remote.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/remote.py‎

Copy file name to clipboardExpand all lines: git/remote.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1068,7 +1068,7 @@ def fetch(
1068	1068	Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_fetch_options)
1069	1069
1070	1070	proc = self.repo.git.fetch(
1071		- "--", self, *args, as_process=True, with_stdout=False, v=verbose, **kwargs
	1071	+ "--", self, *args, as_process=True, with_stdout=False, universal_newlines=False, v=verbose, **kwargs
1072	1072	)
1073	1073	res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
1074	1074	if hasattr(self.repo.odb, "update_cache"):
@@ -1122,7 +1122,7 @@ def pull(
1122	1122	Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_pull_options)
1123	1123
1124	1124	proc = self.repo.git.pull(
1125		- "--", self, refspec, with_stdout=False, as_process=True, universal_newlines=True, v=True, **kwargs
	1125	+ "--", self, refspec, with_stdout=False, as_process=True, universal_newlines=False, v=True, **kwargs
1126	1126	)
1127	1127	res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
1128	1128	if hasattr(self.repo.odb, "update_cache"):

0 commit comments

Comments

0 (0)