Use consistent style for passing logger name · gitpython-developers/GitPython@987dbf4 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 987dbf4

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Use consistent style for passing logger name

This has each module use `__name__` for the path to its own logger. Previously, most modules did this several hard-coded their names in calls to logging.getLogger.

1 parent 307f198 commit 987dbf4
Copy full SHA for 987dbf4

5 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • config.py
  • objects
    • commit.py
    • submodule
      • base.py
      • root.py
  • remote.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/config.py‎

Copy file name to clipboardExpand all lines: git/config.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -61,7 +61,7 @@
61	61	__all__ = ("GitConfigParser", "SectionConstraint")
62	62
63	63
64		- log = logging.getLogger("git.config")
	64	+ log = logging.getLogger(__name__)
65	65	log.addHandler(logging.NullHandler())
66	66
67	67

Collapse file

‎git/objects/commit.py‎

Copy file name to clipboardExpand all lines: git/objects/commit.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -52,7 +52,7 @@
52	52
53	53	# ------------------------------------------------------------------------
54	54
55		- log = logging.getLogger("git.objects.commit")
	55	+ log = logging.getLogger(__name__)
56	56	log.addHandler(logging.NullHandler())
57	57
58	58	__all__ = ("Commit",)

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -56,7 +56,7 @@
56	56	__all__ = ["Submodule", "UpdateProgress"]
57	57
58	58
59		- log = logging.getLogger("git.objects.submodule.base")
	59	+ log = logging.getLogger(__name__)
60	60	log.addHandler(logging.NullHandler())
61	61
62	62

Collapse file

‎git/objects/submodule/root.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/root.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -22,7 +22,7 @@
22	22
23	23	__all__ = ["RootModule", "RootUpdateProgress"]
24	24
25		- log = logging.getLogger("git.objects.submodule.root")
	25	+ log = logging.getLogger(__name__)
26	26	log.addHandler(logging.NullHandler())
27	27
28	28

Collapse file

‎git/remote.py‎

Copy file name to clipboardExpand all lines: git/remote.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -65,7 +65,7 @@
65	65	# -------------------------------------------------------------
66	66
67	67
68		- log = logging.getLogger("git.remote")
	68	+ log = logging.getLogger(__name__)
69	69	log.addHandler(logging.NullHandler())
70	70
71	71

0 commit comments

Comments

0 (0)