Repository navigation
Commit a0f8425
committed
Slightly simplify and clarify instrumented code
1 parent 0300de9 commit a0f8425
1 file changed
Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -763,16 +763,13 @@ def test_handle_process_output(self): | |||
| 763 | 763 | from git.cmd import handle_process_output, safer_popen | |
| 764 | 764 | ||
| 765 | 765 | expected_line_count = 5002 | |
| 766 | - line_counts = [None, 0, 0] | ||
| 767 | - lines = [None, [], []] | ||
| 766 | + actual_lines = [None, [], []] | ||
| 768 | 767 | ||
| 769 | 768 | def stdout_handler(line): | |
| 770 | - line_counts[1] += 1 | ||
| 771 | - lines[1].append(line) | ||
| 769 | + actual_lines[1].append(line) | ||
| 772 | 770 | ||
| 773 | 771 | def stderr_handler(line): | |
| 774 | - line_counts[2] += 1 | ||
| 775 | - lines[2].append(line) | ||
| 772 | + actual_lines[2].append(line) | ||
| 776 | 773 | ||
| 777 | 774 | cmdline = [ | |
| 778 | 775 | sys.executable, | |
@@ -789,8 +786,8 @@ def stderr_handler(line): | |||
| 789 | 786 | ||
| 790 | 787 | handle_process_output(proc, stdout_handler, stderr_handler, finalize_process) | |
| 791 | 788 | ||
| 792 | - self.assertEqual(line_counts[1], expected_line_count, repr(lines[1])) | ||
| 793 | - self.assertEqual(line_counts[2], expected_line_count, repr(lines[2])) | ||
| 789 | + self.assertEqual(len(actual_lines[1]), expected_line_count, repr(actual_lines[1])) | ||
| 790 | + self.assertEqual(len(actual_lines[2]), expected_line_count, repr(actual_lines[2])) | ||
| 794 | 791 | ||
| 795 | 792 | def test_execute_kwargs_set_agrees_with_method(self): | |
| 796 | 793 | parameter_names = inspect.signature(cmd.Git.execute).parameters.keys() | |
0 commit comments