Have `test_installation` test that operations produce no warnings · gitpython-developers/GitPython@a2ba480 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests1 (1)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit a2ba480

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Have test_installation test that operations produce no warnings

By setting the `PYTHONWARNINGS` environment variable to `error` in each of the subprocess invocations. This is strictly stronger than passing `-Werror` for the `python` commands, because it automatically applies to subprocesses (unless they are created with a sanitized environment or otherwise with one in which `PYTHONWARNINGS` has been customized), and because it works for `pip` automatically. Importantly, this will cause warnings internal to Python subprocesses created by `pip` to be treated as errors. It should thus surface any warnings coming from the `setuptools` backend.

1 parent 84632c7 commit a2ba480
Copy full SHA for a2ba480

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_installation.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_installation.py‎

Copy file name to clipboardExpand all lines: test/test_installation.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -64,6 +64,7 @@ def _set_up_venv(rw_dir):
64	64	subprocess.run,
65	65	stdout=subprocess.PIPE,
66	66	cwd=venv.sources,
	67	+ env={**os.environ, "PYTHONWARNINGS": "error"},
67	68	)
68	69
69	70	return venv, run

0 commit comments

Comments

0 (0)