Repository navigation
Commit a315725
committed
Replace use of mktemp
This uses NamedTemporaryFile with delete=False to replace the one
use of the deprecated mktemp function in smmap (reported in #41).
This avoids the race condition inherent to mktemp, as the file is
named and created together in a way that is effectively atomic.
Because NamedTemporaryFile is not being used to automatically
delete the file, it use and cleanup are unaffected by the change.1 parent 7d6f97c commit a315725
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,12 +18,12 @@ class FileCreator: | |||
| 18 | 18 | def __init__(self, size, prefix=''): | |
| 19 | 19 | assert size, "Require size to be larger 0" | |
| 20 | 20 | ||
| 21 | - self._path = tempfile.mktemp(prefix=prefix) | ||
| 22 | 21 | self._size = size | |
| 23 | 22 | ||
| 24 | - with open(self._path, "wb") as fp: | ||
| 25 | - fp.seek(size - 1) | ||
| 26 | - fp.write(b'1') | ||
| 23 | + with tempfile.NamedTemporaryFile("wb", prefix=prefix, delete=False) as file: | ||
| 24 | + self._path = file.name | ||
| 25 | + file.seek(size - 1) | ||
| 26 | + file.write(b'1') | ||
| 27 | 27 | ||
| 28 | 28 | assert os.path.getsize(self.path) == size | |
| 29 | 29 | ||
0 commit comments