test(submodule): close retained parent before checkout removal · gitpython-developers/GitPython@a6c7dba · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests1 (1)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit a6c7dba

Browse filesBrowse the repository at this point in the historyBrowse files

codex

authored and

Byron

committed

test(submodule): close retained parent before checkout removal

The Windows Python 3.14 job for PR #2274 failed in `TestSubmodule.test_base_rw` when forced module-only removal called `rmtree`: Windows reported `WinError 32` for `git/ext/gitdb`. The legacy test retains that checkout's `Repo` through `csm.repo` and starts its persistent `cat-file` process while reading parent commits. Closing only the fresh handle created by `Submodule.remove()` cannot release this caller-owned process. Close the retained test-owned parent before deleting its checkout. Keep strict removal and all existing happy-path assertions, and remove the obsolete commented-out skip that claimed removal ignored this error. The original test predates the PR's base, so record this as a follow-up rather than rewriting shared history. The focused `test_base_rw` passed locally with both CLI and Gix. Relevant pre-commit hooks passed. Hosted Windows validation remains part of the PR CI loop.

1 parent 9ef9ca6 commit a6c7dba
Copy full SHA for a6c7dba

1 file changed

+1-7Lines changed: 1 addition & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_submodule.py‎

Copy file name to clipboardExpand all lines: test/test_submodule.py

+1-7Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1308,6 +1308,7 @@ def _do_base_tests(self, rwrepo):
1308	1308
1309	1309	# Now delete only the module of the main submodule.
1310	1310	assert sm.module_exists()
	1311	+ csm.repo.close()
1311	1312	sm.remove(configuration=False, force=True)
1312	1313	assert sm.exists()
1313	1314	assert not sm.module_exists()
@@ -1410,13 +1411,6 @@ def _do_base_tests(self, rwrepo):
1410	1411	True,
1411	1412	)
1412	1413
1413		- # ACTUALLY skipped by git.util.rmtree (in local onerror function), called via
1414		- # git.objects.submodule.base.Submodule.remove at "method(mp)", line 1011.
1415		- #
1416		- # @skipIf(sys.platform == "win32",
1417		- # "FIXME: fails with: PermissionError: [WinError 32] The process cannot access the file because"
1418		- # "it is being used by another process: "
1419		- # "'C:\\Users\\ankostis\\AppData\\Local\\Temp\\tmp95c3z83bnon_bare_test_base_rw\\git\\ext\\gitdb\\gitdb\\ext\\smmap'") # noqa: E501
1420	1414	@with_rw_repo(k_subm_current)
1421	1415	def test_base_rw(self, rwrepo):
1422	1416	self._do_base_tests(rwrepo)

0 commit comments

Comments

0 (0)