Re-implemented 'user' config level based on suggestion by @jzempel · gitpython-developers/GitPython@acd8246 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues1 (1)
• Pull requests
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit acd8246

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Re-implemented 'user' config level based on suggestion by @jzempel

The point is that XDG_CONFIG_HOME is meant to point at the '.config' directory, whereas '.config' has to be added only if HOME is used instead. Fixes #160

1 parent e84300d commit acd8246
Copy full SHA for acd8246

1 file changed

+2-6Lines changed: 2 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/repo
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/repo/base.py‎

Copy file name to clipboardExpand all lines: git/repo/base.py

+2-6Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -354,12 +354,8 @@ def _get_config_path(self, config_level):
354	354	if config_level == "system":
355	355	return "/etc/gitconfig"
356	356	elif config_level == "user":
357		- for evar in ("XDG_CONFIG_HOME", "HOME"):
358		- if evar not in os.environ:
359		- continue
360		- return os.path.join(os.environ[evar], '.config/git/config')
361		- # end for each evar to check
362		- raise AssertionError("Didn't find a single HOME related environment variable")
	357	+ config_home = os.environ.get("XDG_CONFIG_HOME") or join(os.environ.get("HOME", '~'), ".config")
	358	+ return os.path.expanduser(join(config_home, "git", "config"))
363	359	elif config_level == "global":
364	360	return os.path.normpath(os.path.expanduser("~/.gitconfig"))
365	361	elif config_level == "repository":

0 commit comments

Comments

0 (0)