Fix "OSError: [Errno 36] File name too long" in fuzz_submodule · gitpython-developers/GitPython@af0cd93 · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests7 (7)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit af0cd93

Browse filesBrowse the repository at this point in the historyBrowse files

DaveLak

committed

Fix "OSError: [Errno 36] File name too long" in fuzz_submodule

Fixes a bug in the `fuzz_submodule` harness where the fuzzed data can produce file names that exceed the maximum size allowed byt the OS. This issue came up previously and was fixed in #1922, but the submodule file name fixed here was missed in that PR. Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69456

1 parent 855befa commit af0cd93
Copy full SHA for af0cd93

1 file changed

+5-4Lines changed: 5 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• fuzzing/fuzz-targets
  • fuzz_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎fuzzing/fuzz-targets/fuzz_submodule.py‎

Copy file name to clipboardExpand all lines: fuzzing/fuzz-targets/fuzz_submodule.py

+5-4Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -35,12 +35,13 @@ def TestOneInput(data):
35	35	sub_repo = Repo.init(submodule_temp_dir, bare=fdp.ConsumeBool())
36	36	sub_repo.index.commit(fdp.ConsumeUnicodeNoSurrogates(fdp.ConsumeIntInRange(1, 512)))
37	37
38		- submodule_name = f"submodule_{fdp.ConsumeUnicodeNoSurrogates(fdp.ConsumeIntInRange(1, 512))}"
	38	+ submodule_name = fdp.ConsumeUnicodeNoSurrogates(
	39	+ fdp.ConsumeIntInRange(1, max(1, get_max_filename_length(repo.working_tree_dir)))
	40	+ )
39	41	submodule_path = os.path.join(repo.working_tree_dir, submodule_name)
40		- submodule_url = sub_repo.git_dir
41	42
42		- submodule = repo.create_submodule(submodule_name, submodule_path, url=submodule_url)
43		- repo.index.commit(f"Added submodule {submodule_name}")
	43	+ submodule = repo.create_submodule(submodule_name, submodule_path, url=sub_repo.git_dir)
	44	+ repo.index.commit("Added submodule")
44	45
45	46	with submodule.config_writer() as writer:
46	47	key_length = fdp.ConsumeIntInRange(1, max(1, fdp.remaining_bytes()))

0 commit comments

Comments

0 (0)