Commit b095aa9
committed
Use more compatible hashbangs
This adds a #! line to the top of setup.py, because it is a script
with the executable bit set. Although neither recent nor current
documentation in the project recommends to run "./setup.py", this
should probably have the intuitive effect of attempting to run the
script with a Python interpreter rather than a Unix-style shell.
It also uses the "env trick" in init-tests-after-clone.sh so that
script runs with whatever bash interpreter is found in a normal
PATH search. While "sh" is expected to be found in /bin on all
Unix-like systems, that is not always the case for "bash". This
change slightly improves compatibility by supporting systems that
don't ship with bash but on which it has been installed.1 parent 72e48aa commit b095aa9
2 files changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,9 @@ | |||
| 1 | - #!/bin/bash -e | ||
| 1 | + #!/usr/bin/env bash | ||
| 2 | + | ||
| 3 | + set -e | ||
| 2 | 4 | ||
| 3 | 5 | if [[ -z "$TRAVIS" ]]; then | |
| 4 | - read -p "This operation will destroy locally modified files. Continue ? [N/y]: " answer | ||
| 6 | + read -rp "This operation will destroy locally modified files. Continue ? [N/y]: " answer | ||
| 5 | 7 | if [[ ! $answer =~ [yY] ]]; then | |
| 6 | 8 | exit 2 | |
| 7 | 9 | fi | |
@@ -13,4 +15,4 @@ git reset --hard HEAD~1 | |||
| 13 | 15 | git reset --hard HEAD~1 | |
| 14 | 16 | git reset --hard HEAD~1 | |
| 15 | 17 | git reset --hard __testing_point__ | |
| 16 | - git submodule update --init --recursive | ||
| 18 | + git submodule update --init --recursive | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,3 +1,5 @@ | |||
| 1 | + #!/usr/bin/env python | ||
| 2 | + | ||
| 1 | 3 | from typing import Sequence | |
| 2 | 4 | from setuptools import setup, find_packages | |
| 3 | 5 | from setuptools.command.build_py import build_py as _build_py | |
0 commit comments