Initialize submodule repository before handled failures · gitpython-developers/GitPython@b324c83 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit b324c83

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

and

codex

committed

Initialize submodule repository before handled failures

<!-- agent --> Direct recursive updates with keep_going could swallow an invalid-name validation error and then access mrepo before assignment. Reproduce that path and initialize mrepo before validation so recursion is safely skipped. Git baseline: submodule.c at 883a47ef6496c96a5d6132ed8c87fcd44ebf8d1a validates submodule paths before operating on them. Assisted-by: GPT 5.6 Co-authored-by: GPT 5.6 <codex@openai.com>

1 parent 2212c63 commit b324c83
Copy full SHA for b324c83

3 files changed

+3-11Lines changed: 3 additions & 11 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .basedpyright
  • baseline.json
• git/objects/submodule
  • base.py
• test
  • test_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.basedpyright/baseline.json‎

Copy file name to clipboardExpand all lines: .basedpyright/baseline.json

-8Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -491,14 +491,6 @@
491	491	"lineCount": 1
492	492	}
493	493	},
494		- {
495		- "code": "reportPossiblyUnboundVariable",
496		- "range": {
497		- "startColumn": 15,
498		- "endColumn": 20,
499		- "lineCount": 1
500		- }
501		- },
502	494	{
503	495	"code": "reportArgumentType",
504	496	"range": {

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -747,9 +747,7 @@ def update(
747	747	prefix = "DRY-RUN: "
748	748	# END handle prefix
749	749
750		- # To keep things plausible in dry-run mode.
751		- if dry_run:
752		- mrepo = None
	750	+ mrepo = None
753	751	# END init mrepo
754	752
755	753	def fetch_remotes(module_repo: "Repo") -> None:

Collapse file

‎test/test_submodule.py‎

Copy file name to clipboardExpand all lines: test/test_submodule.py

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -994,6 +994,8 @@ def test_root_update_keeps_going_after_invalid_submodule_name(self, rwdir):
994	994	assert not clone.submodule("../invalid").module_exists()
995	995	assert clone.submodule("valid").module_exists()
996	996
	997	+ clone.submodule("../invalid").update(recursive=True, keep_going=True)
	998	+
997	999	@with_rw_directory
998	1000	@_patch_git_config("protocol.file.allow", "always")
999	1001	def test_list_only_valid_submodules(self, rwdir):

0 commit comments

Comments

0 (0)