Merge pull request #1754 from EliahKagan/no-taskkill · gitpython-developers/GitPython@b8ee9be · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit b8ee9be

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

authored

Merge pull request #1754 from EliahKagan/no-taskkill

Remove unused TASKKILL fallback in AutoInterrupt

2 parents a30b3b7 + 3f21391 commit b8ee9be
Copy full SHA for b8ee9be

1 file changed

+1-11Lines changed: 1 addition & 11 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • cmd.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py

+1-11Lines changed: 1 addition & 11 deletions

Original file line number	Diff line number	Diff line change
@@ -11,7 +11,7 @@
11	11	import logging
12	12	import os
13	13	import signal
14		- from subprocess import call, Popen, PIPE, DEVNULL
	14	+ from subprocess import Popen, PIPE, DEVNULL
15	15	import subprocess
16	16	import threading
17	17	from textwrap import dedent
@@ -544,16 +544,6 @@ def _terminate(self) -> None:
544	544	self.status = self._status_code_if_terminate or status
545	545	except OSError as ex:
546	546	log.info("Ignored error after process had died: %r", ex)
547		- except AttributeError:
548		- # Try Windows.
549		- # For some reason, providing None for stdout/stderr still prints something. This is why
550		- # we simply use the shell and redirect to nul. Slower than CreateProcess. The question
551		- # is whether we really want to see all these messages. It's annoying no matter what.
552		- if os.name == "nt":
553		- call(
554		- ("TASKKILL /F /T /PID %s 2>nul 1>nul" % str(proc.pid)),
555		- shell=True,
556		- )
557	547	# END exception handling
558	548
559	549	def __del__(self) -> None:

0 commit comments

Comments

0 (0)