Repository navigation
Commit bd86c87
Fix AttributeError when searching a remote by name
Running code like `'origin' in git.Repo('path/to/existing/repository').remotes`
raises an AttributeError instead of returning a boolean. This commit fixes that
behaviour by catching the error when doing an identity match on `IterableList`.1 parent e93ffe1 commit bd86c87
2 files changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -32,5 +32,6 @@ Contributors are: | |||
| 32 | 32 | -A. Jesse Jiryu Davis <jesse _at_ emptysquare.net> | |
| 33 | 33 | -Steven Whitman <ninloot _at_ gmail.com> | |
| 34 | 34 | -Stefan Stancu <stefan.stancu _at_ gmail.com> | |
| 35 | + -César Izurieta <cesar _at_ caih.org> | ||
| 35 | 36 | ||
| 36 | 37 | Portions derived from other open source works and are clearly marked. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -864,9 +864,12 @@ def __init__(self, id_attr, prefix=''): | |||
| 864 | 864 | ||
| 865 | 865 | def __contains__(self, attr): | |
| 866 | 866 | # first try identity match for performance | |
| 867 | - rval = list.__contains__(self, attr) | ||
| 868 | - if rval: | ||
| 869 | - return rval | ||
| 867 | + try: | ||
| 868 | + rval = list.__contains__(self, attr) | ||
| 869 | + if rval: | ||
| 870 | + return rval | ||
| 871 | + except (AttributeError, TypeError): | ||
| 872 | + pass | ||
| 870 | 873 | # END handle match | |
| 871 | 874 | ||
| 872 | 875 | # otherwise make a full name search | |
0 commit comments