test(submodule): close retained parent before checkout removal · gitpython-developers/GitPython@bdaf1dc · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues6 (6)
• Pull requests8 (8)
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit bdaf1dc

Browse filesBrowse the repository at this point in the historyBrowse files

codex

authored and

Byron

committed

test(submodule): close retained parent before checkout removal

The Windows Python 3.14 job for PR #2274 failed in `TestSubmodule.test_base_rw` when forced module-only removal called `rmtree`: Windows reported `WinError 32` for `git/ext/gitdb`. The legacy test retains that checkout's `Repo` through `csm.repo` and starts its persistent `cat-file` process while reading parent commits. Closing only the fresh handle created by `Submodule.remove()` cannot release this caller-owned process. Close the retained test-owned parent before deleting its checkout. Keep strict removal and all existing happy-path assertions, and remove the obsolete commented-out skip that claimed removal ignored this error. The original test predates the PR's base, so record this as a follow-up rather than rewriting shared history. The focused `test_base_rw` passed locally with both CLI and Gix. Relevant pre-commit hooks passed. Hosted Windows validation remains part of the PR CI loop.

1 parent 6881712 commit bdaf1dc
Copy full SHA for bdaf1dc

1 file changed

+1-7Lines changed: 1 addition & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_submodule.py‎

Copy file name to clipboardExpand all lines: test/test_submodule.py

+1-7Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1419,6 +1419,7 @@ def _do_base_tests(self, rwrepo):
1419	1419
1420	1420	# Now delete only the module of the main submodule.
1421	1421	assert sm.module_exists()
	1422	+ csm.repo.close()
1422	1423	sm.remove(configuration=False, force=True)
1423	1424	assert sm.exists()
1424	1425	assert not sm.module_exists()
@@ -1521,13 +1522,6 @@ def _do_base_tests(self, rwrepo):
1521	1522	True,
1522	1523	)
1523	1524
1524		- # ACTUALLY skipped by git.util.rmtree (in local onerror function), called via
1525		- # git.objects.submodule.base.Submodule.remove at "method(mp)", line 1011.
1526		- #
1527		- # @skipIf(sys.platform == "win32",
1528		- # "FIXME: fails with: PermissionError: [WinError 32] The process cannot access the file because"
1529		- # "it is being used by another process: "
1530		- # "'C:\\Users\\ankostis\\AppData\\Local\\Temp\\tmp95c3z83bnon_bare_test_base_rw\\git\\ext\\gitdb\\gitdb\\ext\\smmap'") # noqa: E501
1531	1525	@with_rw_repo(k_subm_current)
1532	1526	def test_base_rw(self, rwrepo):
1533	1527	self._do_base_tests(rwrepo)

0 commit comments

Comments

0 (0)