Repository navigation
Commit bdc38b8
committed
Always add '--' to git reset
If a git repo has the misfortune to have a file with the name "HEAD"
at the root level of the repo, git will return an error because it
is unsure whether the file or ref is meant:
File "/usr/local/lib/python2.7/dist-packages/git/refs/head.py", line 81, in reset
self.repo.git.reset(mode, commit, add_arg, paths, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/git/cmd.py", line 440, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/git/cmd.py", line 834, in _call_process
return self.execute(make_call(), **_kwargs)
File "/usr/local/lib/python2.7/dist-packages/git/cmd.py", line 627, in execute
raise GitCommandError(command, status, stderr_value)
GitCommandError: 'git reset --hard HEAD' returned with exit code 128
stderr: 'fatal: ambiguous argument 'HEAD': both revision and filename
Use '--' to separate filenames from revisions'
Implement its suggested fix by always passing '--' as an argument to
"git reset". It is fine to pass it with no file specifiers afterwords.
In that case, git knows that "HEAD" is always meant as the ref.1 parent 58c78e6 commit bdc38b8
1 file changed
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,7 +55,6 @@ def reset(self, commit='HEAD', index=True, working_tree=False, | |||
| 55 | 55 | ||
| 56 | 56 | :return: self""" | |
| 57 | 57 | mode = "--soft" | |
| 58 | - add_arg = None | ||
| 59 | 58 | if index: | |
| 60 | 59 | mode = "--mixed" | |
| 61 | 60 | ||
@@ -73,12 +72,8 @@ def reset(self, commit='HEAD', index=True, working_tree=False, | |||
| 73 | 72 | ||
| 74 | 73 | # END working tree handling | |
| 75 | 74 | ||
| 76 | - if paths: | ||
| 77 | - add_arg = "--" | ||
| 78 | - # END nicely separate paths from rest | ||
| 79 | - | ||
| 80 | 75 | try: | |
| 81 | - self.repo.git.reset(mode, commit, add_arg, paths, **kwargs) | ||
| 76 | + self.repo.git.reset(mode, commit, '--', paths, **kwargs) | ||
| 82 | 77 | except GitCommandError as e: | |
| 83 | 78 | # git nowadays may use 1 as status to indicate there are still unstaged | |
| 84 | 79 | # modifications after the reset | |
0 commit comments