Commit bdd4210
committed
Fix order of operators before executing the git command
Since Python 3.3, the hash value of an object is seeded randomly, making it
change between each call. As a consequence, the `dict` type relying on the hash
value for the order of the items upon iterating on it, and the parameters
passed to `git` being passed as `kwargs` to the `execute()` method, the order
of parameters will change randomly between calls.
For example, when you call `git.remote.pull()` in a code, two consecutives run
will generate:
1. git pull --progress -v origin master
2. git pull -v --progress origin master
By simply adding the `sorted()` call around `args` within the `transform_kwargs()`
method, it will ensure that each subsequent calls will execute the parameters in
the same order.1 parent fb577c8 commit bdd4210
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -789,7 +789,7 @@ def transform_kwargs(self, split_single_char_options=True, **kwargs): | |||
| 789 | 789 | args += self.transform_kwarg(k, value, split_single_char_options) | |
| 790 | 790 | else: | |
| 791 | 791 | args += self.transform_kwarg(k, v, split_single_char_options) | |
| 792 | - return args | ||
| 792 | + return sorted(args) | ||
| 793 | 793 | ||
| 794 | 794 | @classmethod | |
| 795 | 795 | def __unpack_args(cls, arg_list): | |
0 commit comments