In Submodule.iter_items, don't attach second empty iterator · gitpython-developers/GitPython@c3c008c · GitHub

1. gitpython-developers
2. GitPython

Repository navigation

• Code
• Issues1 (1)
• Pull requests
• Discussions
• Actions
• Security and quality42 (42)
• Insights

Commit c3c008c

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

In Submodule.iter_items, don't attach second empty iterator

This fixes the minor bug where a separate empty iterator was bound to the StopIteration exception raised as a result of returning from the generator function (#1779). This change does not cause what exceptions are raised from GitPython code in any situations, nor how many items any iterators yield.

1 parent f5dc1c4 commit c3c008c
Copy full SHA for c3c008c

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/objects/submodule
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1401,7 +1401,7 @@ def iter_items(
1401	1401	pc = repo.commit(parent_commit) # Parent commit instance
1402	1402	parser = cls._config_parser(repo, pc, read_only=True)
1403	1403	except (IOError, BadName):
1404		- return iter([])
	1404	+ return
1405	1405	# END handle empty iterator
1406	1406
1407	1407	for sms in parser.sections():

0 commit comments

Comments

0 (0)