Commit c6d16d0
committed
Start on fixing AutoInterrupt/CatFileContentStream aliases
This uses `TypeAlias` from the `typing` module, to make it so the
assignment statments introduced in #2037 (to set `Git.AutoInterrupt`
and `Git.CatFileContentStream` to nonpublic module-level
implementations `_AutoInterrupt` and `_CatFileContentStream`) are
treated by `mypy` as type aliases rather than as class variables.
For details on the problem this partially fixes, see #2038 and:
https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
The fix won't work in this form, however, because it attempts to
import `TypeAlias` unconditionally from the standard-library
`typing` module, which only gained it in Python 3.10.1 parent 1e463d4 commit c6d16d0
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,6 +55,7 @@ | |||
| 55 | 55 | TYPE_CHECKING, | |
| 56 | 56 | TextIO, | |
| 57 | 57 | Tuple, | |
| 58 | + TypeAlias, | ||
| 58 | 59 | Union, | |
| 59 | 60 | cast, | |
| 60 | 61 | overload, | |
@@ -952,9 +953,9 @@ def check_unsafe_options(cls, options: List[str], unsafe_options: List[str]) -> | |||
| 952 | 953 | f"{unsafe_option} is not allowed, use `allow_unsafe_options=True` to allow it." | |
| 953 | 954 | ) | |
| 954 | 955 | ||
| 955 | - AutoInterrupt = _AutoInterrupt | ||
| 956 | + AutoInterrupt: TypeAlias = _AutoInterrupt | ||
| 956 | 957 | ||
| 957 | - CatFileContentStream = _CatFileContentStream | ||
| 958 | + CatFileContentStream: TypeAlias = _CatFileContentStream | ||
| 958 | 959 | ||
| 959 | 960 | def __init__(self, working_dir: Union[None, PathLike] = None) -> None: | |
| 960 | 961 | """Initialize this instance with: | |
0 commit comments