Use 'echo' where possible to avoid explicit newlines · gitpython-developers/GitPython@d18d90a · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 31
• Insights

Additional navigation options

Commit d18d90a

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Use 'echo' where possible to avoid explicit newlines

1 parent 962f747 commit d18d90a
Copy full SHA for d18d90a

1 file changed

+6-7Lines changed: 6 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• check-version.sh

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎check-version.sh‎

Copy file name to clipboardExpand all lines: check-version.sh

+6-7Lines changed: 6 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -5,27 +5,26 @@
5	5	# You may want to run "make release" instead of running this script directly.
6	6
7	7	set -eEfuo pipefail
8		- trap 'printf "%s: Check failed. Stopping.\n" "$0" >&2' ERR
	8	+ trap 'echo "$0: Check failed. Stopping." >&2' ERR
9	9
10	10	readonly version_path='VERSION'
11	11	readonly changes_path='doc/source/changes.rst'
12	12
13		- printf 'Checking current directory.\n'
	13	+ echo 'Checking current directory.'
14	14	test "$(cd -- "$(dirname -- "$0")" && pwd)" = "$(pwd)" # Ugly, but portable.
15	15
16		- printf 'Checking that %s and %s exist and have no uncommitted changes.\n' \
17		- "$version_path" "$changes_path"
	16	+ echo "Checking that $version_path and $changes_path exist and have no uncommitted changes."
18	17	test -f "$version_path"
19	18	test -f "$changes_path"
20	19	git status -s -- "$version_path" "$changes_path"
21	20	test -z "$(git status -s -- "$version_path" "$changes_path")"
22	21
23	22	# This section can be commented out, if absolutely necessary.
24		- printf 'Checking that ALL changes are committed.\n'
	23	+ echo 'Checking that ALL changes are committed.'
25	24	git status -s --ignore-submodules
26	25	test -z "$(git status -s --ignore-submodules)"
27	26
28		- printf 'Gathering current version, latest tag, and current HEAD commit info.\n'
	27	+ echo 'Gathering current version, latest tag, and current HEAD commit info.'
29	28	version_version="$(cat "$version_path")"
30	29	changes_version="$(awk '/^[0-9]/ {print $0; exit}' "$changes_path")"
31	30	config_opts="$(printf ' -c versionsort.suffix=-%s' alpha beta pre rc RC)"
@@ -44,4 +43,4 @@ printf '%-14s = %s\n' 'VERSION file' "$version_version" \
44	43	test "$version_version" = "$changes_version"
45	44	test "$latest_tag" = "$version_version"
46	45	test "$head_sha" = "$latest_tag_sha"
47		- printf 'OK, everything looks good.\n'
	46	+ echo 'OK, everything looks good.'

0 commit comments

Comments

0 (0)