Address review comment about diff operands · gitpython-developers/GitPython@df56a12 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit df56a12

Browse filesBrowse the repository at this point in the historyBrowse files

codex

authored and

Byron

committed

Address review comment about diff operands

Review comment: The --no-index comment should describe filesystem path operands rather than pathspecs. Use Git terminology so future maintainers are not misled about the command mode. Validation: ruff check, ruff format --check, and git diff --check.

1 parent 1420058 commit df56a12
Copy full SHA for df56a12

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/repo
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/repo/base.py‎

Copy file name to clipboardExpand all lines: git/repo/base.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -209,7 +209,7 @@ class Repo:
209	209	]
210	210
211	211	unsafe_git_diff_options = unsafe_git_revision_options + [
212		- # Treats pathspecs as arbitrary filesystem paths.
	212	+ # Treats path operands as arbitrary filesystem paths.
213	213	"--no-index",
214	214	# Reads caller-controlled order patterns from an arbitrary file.
215	215	"-O",

0 commit comments

Comments

0 (0)