Repository navigation
Commit e8343e2
committed
Firm up comment about is_win in util.is_cygwin_git
The is_cygwin_git function returns False when we have is_win,
because is_win is not True on Cygwin systems. The existing comment
explained why, but was tentative. The claims are accurate, so this
rewrites the comment to state it more definitively.1 parent cd16a35 commit e8343e2
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -419,8 +419,7 @@ def is_cygwin_git(git_executable: PathLike) -> bool: | |||
| 419 | 419 | ||
| 420 | 420 | def is_cygwin_git(git_executable: Union[None, PathLike]) -> bool: | |
| 421 | 421 | if is_win: | |
| 422 | - # is_win seems to be true only for Windows-native pythons | ||
| 423 | - # cygwin has os.name = posix, I think | ||
| 422 | + # is_win is only True on native Windows systems. On Cygwin, os.name == "posix". | ||
| 424 | 423 | return False | |
| 425 | 424 | ||
| 426 | 425 | if git_executable is None: | |
0 commit comments