Help tools know the type of a Commit's `parents` · gitpython-developers/GitPython@fe42ca7 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit fe42ca7

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Help tools know the type of a Commit's parents

mypy seems not to need this, and already infers the specific type List[Commit], but some other type checkers -- at least pylance, and thus probably also pyright -- do not infer this.

1 parent d1ce940 commit fe42ca7
Copy full SHA for fe42ca7

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/objects
  • commit.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/objects/commit.py‎

Copy file name to clipboardExpand all lines: git/objects/commit.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -753,7 +753,7 @@ def _deserialize(self, stream: BytesIO) -> "Commit":
753	753	readline = stream.readline
754	754	self.tree = Tree(self.repo, hex_to_bin(readline().split()[1]), Tree.tree_id << 12, "")
755	755
756		- self.parents = []
	756	+ self.parents = [] # type: List[Commit]
757	757	next_line = None
758	758	while True:
759	759	parent_line = readline()

0 commit comments

Comments

0 (0)