Repository navigation
Commit fe5f8d5
committed
Use the Git class type definition within Repo classmethods
Allow the GitCommandWrapperType definition to be used within the Repo
classmethods. This change follows the intended purpose as stated in
the code, "Subclasses may easily bring in their own custom types by
placing a constructor or type here."
The usecase that prompted this change has to do with
`GIT_SSH_COMMAND`. The goal is to setup a custom `Git` class with
knowledge of the value, something like as follows
```python
from git import Git as BaseGit, Repo as BaseRepo
class Git(BaseGit):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
# For example, assign the SSH command using the current flask
# app's configured setting.
self.update_environment(GIT_SSH_COMMAND=current_app.config['GIT_SSH_COMMAND'])
class Repo(BaseRepo):
GitCommandWrapperType = _Git
```
With this change, the above example will allow the developer to use
`Repo.clone_from(...)` with the indended outcome. Otherwise the
developer will have two differing result when using `Repo(...)` vs
`Repo.clone_from(...)`.1 parent 5b3669e commit fe5f8d5
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1042,7 +1042,7 @@ def init(cls, path: Union[PathLike, None] = None, mkdir: bool = True, odbt: Type | |||
| 1042 | 1042 | os.makedirs(path, 0o755) | |
| 1043 | 1043 | ||
| 1044 | 1044 | # git command automatically chdir into the directory | |
| 1045 | - git = Git(path) | ||
| 1045 | + git = cls.GitCommandWrapperType(path) | ||
| 1046 | 1046 | git.init(**kwargs) | |
| 1047 | 1047 | return cls(path, odbt=odbt) | |
| 1048 | 1048 | ||
@@ -1142,7 +1142,7 @@ def clone_from(cls, url: PathLike, to_path: PathLike, progress: Optional[Callabl | |||
| 1142 | 1142 | :param multi_options: See ``clone`` method | |
| 1143 | 1143 | :param kwargs: see the ``clone`` method | |
| 1144 | 1144 | :return: Repo instance pointing to the cloned directory""" | |
| 1145 | - git = Git(os.getcwd()) | ||
| 1145 | + git = cls.GitCommandWrapperType(os.getcwd()) | ||
| 1146 | 1146 | if env is not None: | |
| 1147 | 1147 | git.update_environment(**env) | |
| 1148 | 1148 | return cls._clone(git, url, to_path, GitCmdObjectDB, progress, multi_options, **kwargs) | |
0 commit comments