Commit c4b0c84
remove code that worked around broken mouse coordinate string passed to clipboard
1 parent dcc4193 commit c4b0c84
2 files changed
Lines changed: 6 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,6 +4,10 @@ | |||
| 4 | 4 | clipboard as a QString. | |
| 5 | 5 | Bug #1602 (and earlier bugs) | |
| 6 | 6 | ||
| 7 | + * src/qtterminal/QtGnuplotScene.cpp (mouseReleaseEvent): With the above | ||
| 8 | + fix in place, it is not necessary to lock out events during the | ||
| 9 | + doubleclick interval. | ||
| 10 | + | ||
| 7 | 11 | 2015-05-30 Ethan A Merritt <merritt@u.washington.edu> | |
| 8 | 12 | ||
| 9 | 13 | * src/qtterminal/QtGnuplotEvent.cpp src/qtterminal/QtGnuplotScene.cpp: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -850,18 +850,8 @@ void QtGnuplotScene::mouseReleaseEvent(QGraphicsSceneMouseEvent* event) | |||
| 850 | 850 | else if (event->button()== Qt::MidButton) button = 2; | |
| 851 | 851 | else if (event->button()== Qt::RightButton) button = 3; | |
| 852 | 852 | ||
| 853 | - // FIXME: If the press/release events get out of order or if we see a very | ||
| 854 | - // fast double-click then the program errors out during event processing. | ||
| 855 | - // Unfortunately I have not been able to reliably filter out these spurious events | ||
| 856 | - // by setting a minimum time window. Maybe an explicit interlock would work? | ||
| 857 | - qint64 time = 301; | ||
| 858 | - if (m_watches[button].isValid()) | ||
| 859 | - time = m_watches[button].elapsed(); | ||
| 860 | - if (time > 300) { | ||
| 861 | - m_eventHandler->postTermEvent(GE_buttonrelease, | ||
| 862 | - int(event->scenePos().x()), int(event->scenePos().y()), button, time, m_widget); | ||
| 863 | - } | ||
| 864 | - m_watches[button].start(); | ||
| 853 | + m_eventHandler->postTermEvent(GE_buttonrelease, | ||
| 854 | + int(event->scenePos().x()), int(event->scenePos().y()), button, 0, m_widget); | ||
| 865 | 855 | ||
| 866 | 856 | /* Check for click in one of the keysample boxes */ | |
| 867 | 857 | int n = m_key_boxes.count(); | |
0 commit comments