Deprecate BatchRequest constructor - #1333
Merged
chingor13 merged 6 commits intoJul 1, 2019
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
kolea2
reviewed
Jul 1, 2019
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchRequest.java
Outdated
kolea2
reviewed
Jul 1, 2019
Comment thread
...api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClient.java
| */ | ||
| public final BatchRequest batch(HttpRequestInitializer httpRequestInitializer) { | ||
| @SuppressWarnings("deprecated") | ||
| BatchRequest batch = |
Copy link
Copy Markdown
There was a problem hiding this comment.
Should we migrate this to the new API?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
This one is the method that users should be using that sets the batch path.
Sorry, something went wrong.
kolea2
reviewed
Jul 1, 2019
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchRequest.java
| * declared by the service configuration. | ||
| */ | ||
| private static final String GLOBAL_BATCH_ENDPOINT = "https://www.googleapis.com/batch"; | ||
| private static final String GLOBAL_BATCH_ENDPOINT_WARNING = "You are using the global batch " |
Copy link
Copy Markdown
There was a problem hiding this comment.
Maybe we can also link to javadoc or a more verbose example?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
We would like to migrate the docs off of developers.google.com for these clients, so I migrated the batching and media upload/download docs to the main README in #1334. That will give us a place to target with this message.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Added a link to the new docs section in the warning message.
Sorry, something went wrong.
kolea2
approved these changes
Jul 1, 2019
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
chingor13
added a commit
that referenced
this pull request
Jul 1, 2019
* Deprecate the BatchRequest public constructor * Update Javadoc sample for batch request * Log a warning if a user is using the global batch endpoint * Fix equality check for Strings * Swap equals comparison to avoid possible NPE * Add URL to visit in the warning message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users should obtain a BatchRequest instance via their client's batch(HttpRequestInitializer) method.