fix: use .read() instead of .content.read() in aiohttp transport (#1899) · googleapis/google-auth-library-python@12f4470 · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.

googleapis / google-auth-library-python Public archive

• Notifications You must be signed in to change notification settings
• Fork 351
• Star 882

• Code
• Issues
• Pull requests
• Actions
• Security and quality
• Insights

Additional navigation options

Commit 12f4470

Browse filesBrowse the repository at this point in the historyBrowse files

google-labs-jules[bot]

and

chalmerlowe

authored

fix: use .read() instead of .content.read() in aiohttp transport (#1899)

Fixes issue where response content is empty when using `aiohttp-client-cache` by using `response.read()` instead of `response.content.read()`. **Rationale:** In `aiohttp`, `.read()` is the standard, high-level method for reading the full response body. It correctly handles internal state (like caching the body for subsequent calls), which is essential for compatibility with wrappers like `aiohttp-client-cache`. Accessing `.content.read()` directly bypasses this logic, leading to empty responses when the stream has already been consumed or intercepted by the caching layer. **Benefits:** - **Robustness:** Ensures correct behavior when `google-auth` is used in conjunction with `aiohttp` wrappers or middleware. - **Standards:** Aligns with `aiohttp` best practices for consuming response bodies. **Risk Mitigation:** - **Behavior:** `_CombinedResponse` is designed to load the full response into memory. Changing to `.read()` preserves this behavior exactly; it just uses a safer accessor. - **Performance:** Since `aiohttp`'s `.read()` returns a reference to the bytes, there is no additional memory overhead compared to the previous implementation. - **Internal:** This change is internal to the transport adapter and does not alter the public API or behavior for users not using caching libraries. --- *PR created automatically by Jules for task [3355868403646689815](https://jules.google.com/task/3355868403646689815) started by @chalmerlowe* --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>

1 parent 94d04e0 commit 12f4470
Copy full SHA for 12f4470

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/auth/transport
  • _aiohttp_requests.py
• tests_async/transport
  • test_aiohttp_requests.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/auth/transport/_aiohttp_requests.py‎

Copy file name to clipboardExpand all lines: google/auth/transport/_aiohttp_requests.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -79,7 +79,7 @@ def data(self):
79	79
80	80	async def raw_content(self):
81	81	if self._raw_content is None:
82		- self._raw_content = await self._response.content.read()
	82	+ self._raw_content = await self._response.read()
83	83	return self._raw_content
84	84
85	85	async def content(self):

Collapse file

‎tests_async/transport/test_aiohttp_requests.py‎

Copy file name to clipboardExpand all lines: tests_async/transport/test_aiohttp_requests.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -40,7 +40,7 @@ def test__is_compressed_not(self):
40	40	@pytest.mark.asyncio
41	41	async def test_raw_content(self):
42	42	mock_response = mock.AsyncMock()
43		- mock_response.content.read.return_value = mock.sentinel.read
	43	+ mock_response.read.return_value = mock.sentinel.read
44	44	combined_response = aiohttp_requests._CombinedResponse(response=mock_response)
45	45	raw_content = await combined_response.raw_content()
46	46	assert raw_content == mock.sentinel.read
@@ -53,7 +53,7 @@ async def test_raw_content(self):
53	53	@pytest.mark.asyncio
54	54	async def test_content(self):
55	55	mock_response = mock.AsyncMock()
56		- mock_response.content.read.return_value = mock.sentinel.read
	56	+ mock_response.read.return_value = mock.sentinel.read
57	57	combined_response = aiohttp_requests._CombinedResponse(response=mock_response)
58	58	content = await combined_response.content()
59	59	assert content == mock.sentinel.read

0 commit comments

Comments

0 (0)