docs: update urllib3 docstrings for v2 compatibility (#1903) · googleapis/google-auth-library-python@3f1aeea · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.

googleapis / google-auth-library-python Public archive

• Notifications You must be signed in to change notification settings
• Fork 351
• Star 882

• Code
• Issues
• Pull requests
• Actions
• Security and quality
• Insights

Additional navigation options

Commit 3f1aeea

Browse filesBrowse the repository at this point in the historyBrowse files

google-labs-jules[bot]

and

chalmerlowe

authored

docs: update urllib3 docstrings for v2 compatibility (#1903)

Updates docstrings in `google/auth/transport/urllib3.py` to reference `urllib3.PoolManager` instead of the removed/private `urllib3.request.RequestMethods`, ensuring compatibility with `urllib3` v2 documentation standards. NOTE: This PR supercedes an [older PR #1290](#1290), because some of the content or suggested changes in the older PR are overtaken by events and/or been incorporated via [other recent PRs](#1389). --- *PR created automatically by Jules for task [17649723998293325458](https://jules.google.com/task/17649723998293325458) started by @chalmerlowe* Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>

1 parent f9e9187 commit 3f1aeea
Copy full SHA for 3f1aeea

1 file changed

+3-4Lines changed: 3 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/auth/transport
  • urllib3.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/auth/transport/urllib3.py‎

Copy file name to clipboardExpand all lines: google/auth/transport/urllib3.py

+3-4Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -106,9 +106,8 @@ class Request(transport.Request):
106	106	credentials.refresh(request)
107	107
108	108	Args:
109		- http (urllib3.request.RequestMethods): An instance of any urllib3
110		- class that implements :class:`~urllib3.request.RequestMethods`,
111		- usually :class:`urllib3.PoolManager`.
	109	+ http (urllib3.PoolManager): An instance of a urllib3 class that implements
	110	+ the request interface (e.g. :class:`urllib3.PoolManager`).
112	111
113	112	.. automethod:: __call__
114	113	"""
@@ -209,7 +208,7 @@ class AuthorizedHttp(RequestMethods): # type: ignore
209	208	response = authed_http.request(
210	209	'GET', 'https://www.googleapis.com/storage/v1/b')
211	210
212		- This class implements :class:`urllib3.request.RequestMethods` and can be
	211	+ This class implements the urllib3 request interface and can be
213	212	used just like any other :class:`urllib3.PoolManager`.
214	213
215	214	The underlying :meth:`urlopen` implementation handles adding the

0 commit comments

Comments

0 (0)