FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bigtable::SetCell should only accept millisecond timestamps. · Issue #274 · googleapis/google-cloud-cpp · GitHub

bigtable::SetCell should only accept millisecond timestamps. #274

Description

The current API is confusing the signature is:

Mutation SetCell(std::string family, std::string column, std::int64_t timestamp,
                 std::string value);

However the timestamp value must be a multiple of 1,000. That is error prone, we are giving users the impression that they can set the timestamp to values like 42, when in fact they cannot.
We should make the API less error prone, and make it:

Mutation SetCell(std::string family, std::string column, std::chrono::milliseconds timestamp,
                 std::string value);

When the server supports microsecond timestamps we can add a new overload:

Mutation SetCell(std::string family, std::string column, std::chrono::microseconds timestamp,
                 std::string value);

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: bigtableIssues related to the Bigtable API.triage meI really want to be triaged.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions


Back | FazBrowse Home | New Git URL