fix(storage): Current object generation takeover. (#12383) · googleapis/google-cloud-go@9ca8e01 · GitHub

googleapis / google-cloud-go Public

• Notifications You must be signed in to change notification settings
• Fork 1.6k
• Star 4.5k

• Code
• Issues 279
• Pull requests 151
• Actions
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 9ca8e01

Browse filesBrowse the repository at this point in the historyBrowse files

cjc25

authored

fix(storage): Current object generation takeover. (#12383)

Correct handling when the caller specifies takeover for the current object generation. The previous behavior was inconsistent: it opened a writer when the user specified: ``` c.Bucket(b).Object(o).Generation(0).NewWriterFromAppendableObject(...) ``` But in the internal writer code would only perform takeovers for generations greater than 0.

1 parent d044e6f commit 9ca8e01
Copy full SHA for 9ca8e01

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• storage
  • grpc_writer.go

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎storage/grpc_writer.go‎

Copy file name to clipboardExpand all lines: storage/grpc_writer.go

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -114,7 +114,7 @@ func (c *grpcStorageClient) OpenWriter(params *openWriterParams, opts ...storage
114	114
115	115	// If we are taking over an appendable object, send the first message here
116	116	// to get the append offset.
117		- if params.appendGen > 0 {
	117	+ if params.append && params.appendGen >= 0 {
118	118	// Create the buffer sender. This opens a stream and blocks until we
119	119	// get a response that tells us what offset to write from.
120	120	wbs, err := gw.newGRPCAppendTakeoverWriteBufferSender(params.ctx)
@@ -223,7 +223,7 @@ func newGRPCWriter(c *grpcStorageClient, s *settings, params *openWriterParams,
223	223	Appendable: proto.Bool(params.append),
224	224	}
225	225	var appendSpec *storagepb.AppendObjectSpec
226		- if params.appendGen > 0 {
	226	+ if params.append && params.appendGen >= 0 {
227	227	appendSpec = &storagepb.AppendObjectSpec{
228	228	Bucket: bucketResourceName(globalProjectAlias, params.bucket),
229	229	Object: params.attrs.Name,

0 commit comments

Comments

0 (0)