fix: Make LoggingHandler.logEntryFor extensible (#1021) · googleapis/google-cloud-java@79baac6 · GitHub

googleapis / google-cloud-java Public

• Notifications You must be signed in to change notification settings
• Fork 1.2k
• Star 2.1k

• Code
• Issues 691
• Pull requests 158
• Actions
• Security and quality
• Insights

Additional navigation options

Commit 79baac6

Browse filesBrowse the repository at this point in the historyBrowse files

authored

fix: Make LoggingHandler.logEntryFor extensible (#1021)

* feat: Make LoggingHandler.logEntryFor extensible * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Ben Creech <bpcreech@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

1 parent 8c9a218 commit 79baac6
Copy full SHA for 79baac6

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google-cloud-logging/src/main/java/com/google/cloud/logging
  • LoggingHandler.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java‎

Copy file name to clipboardExpand all lines: google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -306,7 +306,7 @@ public void publish(LogRecord record) {
306	306	}
307	307	LogEntry logEntry;
308	308	try {
309		- logEntry = logEntryFor(record);
	309	+ logEntry = logEntryFor(record).build();
310	310	} catch (Exception ex) {
311	311	getErrorManager().error(null, ex, ErrorManager.FORMAT_FAILURE);
312	312	return;
@@ -344,7 +344,7 @@ public void publish(LogRecord record) {
344	344	return null;
345	345	}
346	346
347		- private LogEntry logEntryFor(LogRecord record) throws Exception {
	347	+ protected LogEntry.Builder logEntryFor(LogRecord record) throws Exception {
348	348	String payload = getFormatter().format(record);
349	349	Level level = record.getLevel();
350	350	LogEntry.Builder builder =
@@ -361,7 +361,7 @@ private LogEntry logEntryFor(LogRecord record) throws Exception {
361	361	for (LoggingEnhancer enhancer : enhancers) {
362	362	enhancer.enhanceLogEntry(builder);
363	363	}
364		- return builder.build();
	364	+ return builder;
365	365	}
366	366
367	367	@Override

0 commit comments

Comments

0 (0)