FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make job configuration classes final · googleapis/google-cloud-java@d1d3463 · GitHub

/ google-cloud-java Public

Commit d1d3463

Browse files
mziccard
committed
Make job configuration classes final
1 parent bd53cca commit d1d3463

4 files changed

Lines changed: 29 additions & 33 deletions

File tree

‎gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/CopyJobConfiguration.java‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* Google BigQuery copy job configuration. A copy job copies an existing table to another new or
3232
* existing table. Copy job configurations have {@link JobConfiguration.Type#COPY} type.
3333
*/
34-
public class CopyJobConfiguration extends JobConfiguration {
34+
public final class CopyJobConfiguration extends JobConfiguration {
3535

3636
private static final long serialVersionUID = 1140509641399762967L;
3737

@@ -180,15 +180,14 @@ ToStringHelper toStringHelper() {
180180
}
181181

182182
@Override
183-
public final boolean equals(Object obj) {
183+
public boolean equals(Object obj) {
184184
return obj == this
185-
|| obj != null
186-
&& obj.getClass().equals(CopyJobConfiguration.class)
185+
|| obj instanceof CopyJobConfiguration
187186
&& baseEquals((CopyJobConfiguration) obj);
188187
}
189188

190189
@Override
191-
public final int hashCode() {
190+
public int hashCode() {
192191
return Objects.hash(baseHashCode(), sourceTables, destinationTable, createDisposition,
193192
writeDisposition);
194193
}

‎gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/ExtractJobConfiguration.java‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* Cloud Storage. The extract destination provided as URIs that point to objects in Google Cloud
3131
* Storage. Extract job configurations have {@link JobConfiguration.Type#EXTRACT} type.
3232
*/
33-
public class ExtractJobConfiguration extends JobConfiguration {
33+
public final class ExtractJobConfiguration extends JobConfiguration {
3434

3535
private static final long serialVersionUID = 4147749733166593761L;
3636

@@ -210,15 +210,14 @@ ToStringHelper toStringHelper() {
210210
}
211211

212212
@Override
213-
public final boolean equals(Object obj) {
213+
public boolean equals(Object obj) {
214214
return obj == this
215-
|| obj != null
216-
&& obj.getClass().equals(ExtractJobConfiguration.class)
215+
|| obj instanceof ExtractJobConfiguration
217216
&& baseEquals((ExtractJobConfiguration) obj);
218217
}
219218

220219
@Override
221-
public final int hashCode() {
220+
public int hashCode() {
222221
return Objects.hash(baseHashCode(), sourceTable, destinationUris, printHeader, fieldDelimiter,
223222
format, compression);
224223
}

‎gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/LoadJobConfiguration.java‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* table. Data is provided as URIs that point to objects in Google Cloud Storage. Load job
3131
* configurations have {@link JobConfiguration.Type#LOAD} type.
3232
*/
33-
public class LoadJobConfiguration extends JobConfiguration implements LoadConfiguration {
33+
public final class LoadJobConfiguration extends JobConfiguration implements LoadConfiguration {
3434

3535
private static final long serialVersionUID = -2673554846792429829L;
3636

@@ -268,15 +268,14 @@ ToStringHelper toStringHelper() {
268268
}
269269

270270
@Override
271-
public final boolean equals(Object obj) {
271+
public boolean equals(Object obj) {
272272
return obj == this
273-
|| obj != null
274-
&& obj.getClass().equals(LoadJobConfiguration.class)
273+
|| obj instanceof LoadJobConfiguration
275274
&& baseEquals((LoadJobConfiguration) obj);
276275
}
277276

278277
@Override
279-
public final int hashCode() {
278+
public int hashCode() {
280279
return Objects.hash(baseHashCode(), sourceUris);
281280
}
282281

‎gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/QueryJobConfiguration.java‎

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,23 @@
3535
* Google BigQuery Query Job configuration. A Query Job runs a query against BigQuery data. Query
3636
* job configurations have {@link JobConfiguration.Type#QUERY} type.
3737
*/
38-
public class QueryJobConfiguration extends JobConfiguration {
38+
public final class QueryJobConfiguration extends JobConfiguration {
3939

4040
private static final long serialVersionUID = -1108948249081804890L;
4141

42+
private final String query;
43+
private final TableId destinationTable;
44+
private final Map<String, ExternalTableDefinition> tableDefinitions;
45+
private final List<UserDefinedFunction> userDefinedFunctions;
46+
private final CreateDisposition createDisposition;
47+
private final WriteDisposition writeDisposition;
48+
private final DatasetId defaultDataset;
49+
private final Priority priority;
50+
private final Boolean allowLargeResults;
51+
private final Boolean useQueryCache;
52+
private final Boolean flattenResults;
53+
private final Boolean dryRun;
54+
4255
/**
4356
* Priority levels for a query. If not specified the priority is assumed to be
4457
* {@link Priority#INTERACTIVE}.
@@ -59,19 +72,6 @@ public enum Priority {
5972
BATCH
6073
}
6174

62-
private final String query;
63-
private final TableId destinationTable;
64-
private final Map<String, ExternalTableDefinition> tableDefinitions;
65-
private final List<UserDefinedFunction> userDefinedFunctions;
66-
private final CreateDisposition createDisposition;
67-
private final WriteDisposition writeDisposition;
68-
private final DatasetId defaultDataset;
69-
private final Priority priority;
70-
private final Boolean allowLargeResults;
71-
private final Boolean useQueryCache;
72-
private final Boolean flattenResults;
73-
private final Boolean dryRun;
74-
7575
public static final class Builder
7676
extends JobConfiguration.Builder<QueryJobConfiguration, Builder> {
7777

@@ -449,15 +449,14 @@ ToStringHelper toStringHelper() {
449449
}
450450

451451
@Override
452-
public final boolean equals(Object obj) {
452+
public boolean equals(Object obj) {
453453
return obj == this
454-
|| obj != null
455-
&& obj.getClass().equals(QueryJobConfiguration.class)
454+
|| obj instanceof QueryJobConfiguration
456455
&& baseEquals((QueryJobConfiguration) obj);
457456
}
458457

459458
@Override
460-
public final int hashCode() {
459+
public int hashCode() {
461460
return Objects.hash(baseHashCode(), allowLargeResults, createDisposition, destinationTable,
462461
defaultDataset, flattenResults, priority, query, tableDefinitions, useQueryCache,
463462
userDefinedFunctions, writeDisposition, dryRun);

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL