feat: [servicemanagement] Add a proto message to describe the resource_type and resource_permission for an API method - #9687
Merged
JoeWang1127 merged 4 commits intoAug 3, 2023
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Owl bot is regenerating pull request 9687... |
Sorry, something went wrong.
gcf-owl-bot
Bot
force-pushed
the
owl-bot-copy-java-service-management
branch
from
b9f74d9 to
9459324
Compare
August 2, 2023 18:48
Copy link
Copy Markdown
Contributor
|
Unit test failed: 2023-08-02T19:20:02.8366411Z 19:20:02:834 [ERROR] com.google.cloud.api.servicemanagement.v1.ServiceManagerClientHttpJsonTest.getIamPolicyTest Time elapsed: 0.026 s <<< ERROR! 2023-08-02T19:20:02.8385944Z com.google.api.gax.rpc.NotFoundException: 2023-08-02T19:20:02.8386737Z com.google.api.client.http.HttpResponseException: 404 2023-08-02T19:20:02.8388119Z POST https://servicemanagement.googleapis.com:443/v1/GetIamPolicyRequest-1527610370:getIamPolicy?$alt=json;enum-encoding%3Dint 2023-08-02T19:20:02.8388880Z Method not found for path 'https:///v1/GetIamPolicyRequest-1527610370:getIamPolicy' 2023-08-02T19:20:02.8389448Z at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:90) 2023-08-02T19:20:02.8390089Z at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:41) 2023-08-02T19:20:02.8390852Z at com.google.api.gax.httpjson.HttpJsonApiExceptionFactory.createApiException(HttpJsonApiExceptionFactory.java:75) 2023-08-02T19:20:02.8391650Z at com.google.api.gax.httpjson.HttpJsonApiExceptionFactory.create(HttpJsonApiExceptionFactory.java:54) 2023-08-02T19:20:02.8392432Z at com.google.api.gax.httpjson.HttpJsonExceptionCallable$ExceptionTransformingFuture.onFailure(HttpJsonExceptionCallable.java:97) 2023-08-02T19:20:02.8393145Z at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:84) 2023-08-02T19:20:02.8393609Z at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1127) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Owl bot is regenerating pull request 9687... |
Sorry, something went wrong.
…ce_permission` for an API method PiperOrigin-RevId: 550688034 Source-Link: googleapis/googleapis@52a738b Source-Link: https://github.com/googleapis/googleapis-gen/commit/a4242e487cb71adc5cbc5c356348b77ff477f03a Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6ImE0MjQyZTQ4N2NiNzFhZGM1Y2JjNWMzNTYzNDhiNzdmZjQ3N2YwM2EifQ==
gcf-owl-bot
Bot
force-pushed
the
owl-bot-copy-java-service-management
branch
from
d32b102 to
aa3c8d0
Compare
August 2, 2023 20:37
Copy link
Copy Markdown
Member
|
FYI @JoeWang1127, this issue has been logged here: #12490 We've decided to ignore these test for now. For some reason the owlbot ignore here: isn't working properlyI'll need to take another look. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@lqiu96 I think this line is to reserve the file, not to ignore it. |
Sorry, something went wrong.
lqiu96
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 550688034
Source-Link: googleapis/googleapis@52a738b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a4242e487cb71adc5cbc5c356348b77ff477f03a
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6ImE0MjQyZTQ4N2NiNzFhZGM1Y2JjNWMzNTYzNDhiNzdmZjQ3N2YwM2EifQ==