feat: format page number in table widget (#1992) · googleapis/google-cloud-python@1710489 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 97
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1710489

Browse filesBrowse the repository at this point in the historyBrowse files

shuoweil

authored

feat: format page number in table widget (#1992)

1 parent ca16c8c commit 1710489
Copy full SHA for 1710489

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/bigframes/bigframes/display
  • table_widget.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/bigframes/bigframes/display/table_widget.js‎

Copy file name to clipboardExpand all lines: packages/bigframes/bigframes/display/table_widget.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -88,7 +88,9 @@ function render({ model, el }) {
88	88	const totalPages = Math.ceil(rowCount / pageSize);
89	89
90	90	rowCountLabel.textContent = `${rowCount.toLocaleString()} total rows`;
91		- paginationLabel.textContent = `Page ${currentPage + 1} of ${totalPages || 1}`;
	91	+ paginationLabel.textContent = `Page ${(
	92	+ currentPage + 1
	93	+ ).toLocaleString()} of ${(totalPages || 1).toLocaleString()}`;
92	94	prevPage.disabled = currentPage === 0;
93	95	nextPage.disabled = currentPage >= totalPages - 1;
94	96	pageSizeSelect.value = pageSize;

0 commit comments

Comments

0 (0)