Addressing review comment (commit to be squashed). · googleapis/google-cloud-python@2399a0d · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 444
• Pull requests 98
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2399a0d

Browse filesBrowse the repository at this point in the historyBrowse files

dhermes

committed

Addressing review comment (commit to be squashed).

1 parent 876efc3 commit 2399a0d
Copy full SHA for 2399a0d

1 file changed

+3-6Lines changed: 3 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gcloud/bigtable
  • test_row_data.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gcloud/bigtable/test_row_data.py‎

Copy file name to clipboardExpand all lines: gcloud/bigtable/test_row_data.py

+3-6Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -170,12 +170,9 @@ def test_to_dict(self):
170	170	}
171	171
172	172	result = partial_row_data.to_dict()
173		- col1 = family_name1.encode('ascii') + b':' + qual1
174		- col2 = family_name1.encode('ascii') + b':' + qual2
175		- col3 = family_name2.encode('ascii') + b':' + qual3
176	173	expected_result = {
177		- col1: cell1,
178		- col2: cell2,
179		- col3: cell3,
	174	+ b'name1:col1': cell1,
	175	+ b'name1:col2': cell2,
	176	+ b'name2:col3': cell3,
180	177	}
181	178	self.assertEqual(result, expected_result)

0 commit comments

Comments

0 (0)