#295 let entity save accept null value for attribute · googleapis/google-cloud-python@3753821 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 96
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3753821

Browse filesBrowse the repository at this point in the historyBrowse files

lucemia

committed

#295 let entity save accept null value for attribute

1 parent b6d3e74 commit 3753821
Copy full SHA for 3753821

2 files changed

+17Lines changed: 17 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gcloud/datastore
  • helpers.py
  • test_helpers.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gcloud/datastore/helpers.py‎

Copy file name to clipboardExpand all lines: gcloud/datastore/helpers.py

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -222,6 +222,9 @@ def _set_protobuf_value(value_pb, val):
222	222	:class:`gcloud.datastore.entity.Entity`,
223	223	:param val: The value to be assigned.
224	224	"""
	225	+ if val is None:
	226	+ return
	227	+
225	228	attr, val = _get_protobuf_attribute_and_value(val)
226	229	if attr == 'key_value':
227	230	value_pb.key_value.CopyFrom(val)

Collapse file

‎gcloud/datastore/test_helpers.py‎

Copy file name to clipboardExpand all lines: gcloud/datastore/test_helpers.py

+14Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -361,6 +361,20 @@ def test_key(self):
361	361	value = pb.key_value
362	362	self.assertEqual(value, key.to_protobuf())
363	363
	364	+ def test_none(self):
	365	+ pb = self._makePB()
	366	+ self._callFUT(pb, None)
	367	+ self.assertEqual(pb.HasField('boolean_value'), False)
	368	+ self.assertEqual(pb.HasField('integer_value'), False)
	369	+ self.assertEqual(pb.HasField('double_value'), False)
	370	+ self.assertEqual(pb.HasField('timestamp_microseconds_value'), False)
	371	+ self.assertEqual(pb.HasField('key_value'), False)
	372	+ self.assertEqual(pb.HasField('blob_key_value'), False)
	373	+ self.assertEqual(pb.HasField('string_value'), False)
	374	+ self.assertEqual(pb.HasField('blob_value'), False)
	375	+ self.assertEqual(pb.HasField('entity_value'), False)
	376	+ self.assertEqual(len(pb.list_value), 0)
	377	+
364	378	def test_bool(self):
365	379	pb = self._makePB()
366	380	self._callFUT(pb, False)

0 commit comments

Comments

0 (0)