BQ: wait for load jobs to complete in system tests. · googleapis/google-cloud-python@69a7849 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 444
• Pull requests 99
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 69a7849

Browse filesBrowse the repository at this point in the historyBrowse files

tswast

committed

BQ: wait for load jobs to complete in system tests.

Specify job ID in BQ DB-API DML tests to allow for further test flake debugging.

1 parent 5b4b8fa commit 69a7849
Copy full SHA for 69a7849

1 file changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• bigquery/tests
  • system.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎bigquery/tests/system.py‎

Copy file name to clipboardExpand all lines: bigquery/tests/system.py

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -381,6 +381,7 @@ def test_load_table_from_local_file_then_dump_table(self):
381	381	)
382	382
383	383	# Retry until done.
	384	+ job.result()
384	385	retry = RetryInstanceState(_job_done, max_tries=8)
385	386	retry(job.reload)()
386	387
@@ -419,6 +420,7 @@ def test_load_table_from_local_avro_file_then_dump_table(self):
419	420	)
420	421
421	422	# Retry until done.
	423	+ job.result()
422	424	retry = RetryInstanceState(_job_done, max_tries=8)
423	425	retry(job.reload)()
424	426
@@ -770,6 +772,7 @@ def _load_table_for_dml(self, rows, dataset_name, table_name):
770	772	)
771	773
772	774	# Retry until done.
	775	+ job.result()
773	776	retry = RetryInstanceState(_job_done, max_tries=8)
774	777	retry(job.reload)()
775	778	self._fetch_single_page(table)
@@ -799,7 +802,9 @@ def test_dbapi_w_dml(self):
799	802	WHERE greeting = 'Hello World'
800	803	"""
801	804
802		- Config.CURSOR.execute(query_template.format(dataset_name, table_name))
	805	+ Config.CURSOR.execute(
	806	+ query_template.format(dataset_name, table_name),
	807	+ job_id='test_dbapi_w_dml_{}'.format(str(uuid.uuid4())))
803	808	self.assertEqual(Config.CURSOR.rowcount, 1)
804	809	self.assertIsNone(Config.CURSOR.fetchone())
805	810

0 commit comments

Comments

0 (0)