Raise ValueError if credentials are not from google-auth (#2828) · googleapis/google-cloud-python@8097265 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 128
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8097265

Browse filesBrowse the repository at this point in the historyBrowse files

Jon Wayne Parrott

authored

Raise ValueError if credentials are not from google-auth (#2828)

1 parent 6abb471 commit 8097265
Copy full SHA for 8097265

2 files changed

+9-1Lines changed: 9 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/google-cloud-runtimeconfig
  • tox.ini
  • unit_tests
    • test_client.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/google-cloud-runtimeconfig/tox.ini‎

Copy file name to clipboardExpand all lines: packages/google-cloud-runtimeconfig/tox.ini

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -7,6 +7,7 @@ localdeps =
7	7	pip install --quiet --upgrade {toxinidir}/../core
8	8	deps =
9	9	{toxinidir}/../core
	10	+ mock
10	11	pytest
11	12	covercmd =
12	13	py.test --quiet \

Collapse file

‎packages/google-cloud-runtimeconfig/unit_tests/test_client.py‎

Copy file name to clipboardExpand all lines: packages/google-cloud-runtimeconfig/unit_tests/test_client.py

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -14,6 +14,13 @@
14	14
15	15	import unittest
16	16
	17	+ import mock
	18	+
	19	+
	20	+ def _make_credentials():
	21	+ import google.auth.credentials
	22	+ return mock.Mock(spec=google.auth.credentials.Credentials)
	23	+
17	24
18	25	class TestClient(unittest.TestCase):
19	26
@@ -28,7 +35,7 @@ def _make_one(self, *args, **kw):
28	35	def test_config(self):
29	36	PROJECT = 'PROJECT'
30	37	CONFIG_NAME = 'config_name'
31		- creds = object()
	38	+ creds = _make_credentials()
32	39
33	40	client_obj = self._make_one(project=PROJECT, credentials=creds)
34	41	new_config = client_obj.config(CONFIG_NAME)

0 commit comments

Comments

0 (0)